Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for secretName in PV volumeAttributes to override the default #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cameronbraid
Copy link
Contributor

No description provided.

@cameronbraid
Copy link
Contributor Author

I'd also like it to look for the secret in the same namespace as the PV/PVC

Is there any way to get this info ?

Copy link

@floretan floretan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for now, although I haven't tested it. Let's do some more review when we start using this new functionality.

@Jancis
Copy link
Member

Jancis commented Mar 20, 2020

Can't read secret from another namespace, unfortunately

Secret resources reside in a namespace . Secrets can only be referenced by Pods in that same namespace.
https://kubernetes.io/docs/concepts/configuration/secret/#details

@dvcrn
Copy link

dvcrn commented Nov 6, 2022

This PR is 2 years old at this point, but I went ahead and merged it into my fork https://github.com/dvcrn/csi-rclone-reloaded

Hope upstream will reconsider it

@Jancis
Copy link
Member

Jancis commented Nov 21, 2022

I was under impression this does not work due to technical limitation. Should probably test it.
I love the fork and examples in readme 👍
There is not much work done on this for a while as we've been using filestore and trying out nfs provisioner with hosted nfs server. It handles plugin container restarts way better.
Still, we have few ideas to change about this module in the backlog and since CSI spec seems to have changed a bit it will require at least partial rewrite anyway.

@dvcrn
Copy link

dvcrn commented Nov 22, 2022

I was under impression this does not work due to technical limitation. Should probably test it.

You just made me retry this to make sure 😄
The secret needs in the same namespace as the controller, then everything is fine. So in my fork that would be kube-system

Let me add it to the README

@danielloader
Copy link

danielloader commented Jul 15, 2023

This PR is 2 years old at this point, but I went ahead and merged it into my fork https://github.com/dvcrn/csi-rclone-reloaded

Hope upstream will reconsider it

@dvcrn Just found this but your fork doesn’t include issues. Fancy merging #46 too?

@dvcrn
Copy link

dvcrn commented Jul 22, 2023

Oh, Issues were not supposed to be off, I've enabled them.

I'll put it on my todo list but may take a bit until I get to it!

@Rade333 Rade333 requested a review from Jancis August 17, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants